feat: correctly propagate storage_options#514
Merged
tchaton merged 2 commits intoLightning-AI:mainfrom Mar 20, 2025
Merged
Conversation
deependujha
requested review from
justusschock,
lantiga and
tchaton
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #514 +/- ##
===================================
- Coverage 79% 79% -0%
===================================
Files 39 39
Lines 5859 5862 +3
===================================
+ Hits 4621 4623 +2
- Misses 1238 1239 +1 🚀 New features to boost your workflow:
|
tchaton
approved these changes
Mar 14, 2025
Collaborator
tchaton
left a comment
tchaton
left a comment
There was a problem hiding this comment.
Mind adding a few tests ?
Collaborator
Author
|
Hi @tchaton And, also testing for It'd be best to have it in the next pr. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
Fixes # (issue).
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃